NMS-16486: Extracted caches from DocumentEnricherImpl #7397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
christianpape
commented
Aug 28, 2024
christianpape
commented
- JIRA: https://opennms.atlassian.net/browse/NMS-16486
christianpape
force-pushed
the
jira/NMS-16486
branch
from
dfa7fb5
to
1799458
Compare
indigo423
approved these changes
Aug 28, 2024
| http://aries.apache.org/schemas/blueprint-ext/blueprint-ext-1.1.xsd | ||
| "> | ||
| <!-- Configuration properties --> | ||
| <cm:property-placeholder id="cacheConfigProperties" persistent-id="org.opennms.features.telemetry.protocols.common" update-strategy="reload"> |
There was a problem hiding this comment.
I think it makes sense to create a documentation enhancement to add all these new configuration properties to the docs and make it a requirement when we decide to merge this into an official release. It's not a blocker for the merge into NMS-16375.
There was a problem hiding this comment.
Good catch. Yes, we have to add these to the docs.
fooker
requested changes
Aug 28, 2024
Yes, you are totally right. The common.cache is a leftover of changes I reverted. I'll fix that. |
christianpape
force-pushed
the
jira/NMS-16486
branch
2 times, most recently
from
a6e7326
to
16a33b7
Compare
fooker
approved these changes
Aug 29, 2024
christianpape
force-pushed
the
jira/NMS-16486
branch
from
16a33b7
to
15df160
Compare
christianpape
force-pushed
the
jira/NMS-16486
branch
from
15df160
to
1d723d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.